fix: client close blockstore on store directory and store blob #1198
Conversation
|
|
||
| try { | ||
| const { cid, car } = await NFTStorage.encodeBlob(blob, blockstore) | ||
| await NFTStorage.storeCar(service, car) |
There was a problem hiding this comment.
We can as an alternative do this within storeCar, but we would need to provide blockstore here, which feels odd as we don't even use ipfs-car related things in the function. Also, wrapping everything to guarantee error handling looked the best option
There was a problem hiding this comment.
In my opinion, this can be redesigned as if a user want to store a big chunk, let's say 10GB, they need to have it available in tmpfs at once. I would recommend to have only the last pending blocks in the tmpfs and delete them after uploading.
There was a problem hiding this comment.
We are working on a new solution to pack files that will stream directly instead of using a temporary blockstore to keep the blocks. So, this will be an enhancement that we will ship soon to improve this behaviour #980
Deploying with
|
| Latest commit: |
cbc9eee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55147c2c.nft-storage-1at.pages.dev |
vasco-santos
force-pushed
the
fix/client-close-blockstore-on-store-directory-and-store-blob
branch
3 times, most recently
from
1616099
to
92eda73
Compare
vasco-santos
force-pushed
the
fix/client-close-blockstore-on-store-directory-and-store-blob
branch
from
92eda73
to
cbc9eee
Compare
Codecov Report
@@ Coverage Diff @@
## main #1198 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1136 1169 +33
=========================================
+ Hits 1136 1169 +33
Continue to review full report at Codecov.
|
vasco-santos
deleted the
fix/client-close-blockstore-on-store-directory-and-store-blob
branch
Given we use a CarReader now, we can only close the blockstore once pack is finished.
Also updated @web-std/fetch to avoid
Error: Cannot find module '/home/runner/work/nft.storage/nft.storage/node_modules/@web-std/fetch/dist/index.cjs'Closes #1186