feat: content_cid not id is used from nft data upload not uploads #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5ce1404
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79c227f5.nft-storage-1at.pages.dev |
dashcraft
changed the title
alanshaw
requested changes
Apr 4, 2022
packages/api/src/utils/db-client.js
Outdated
| @@ -125,20 +125,20 @@ export class DBClient { | |||
| updated_at: now, | |||
| }) | |||
| .select(this.uploadQuery) | |||
| .eq('id', data.id) | |||
| .eq('content_cid', data.content_cid) | |||
There was a problem hiding this comment.
We need to update the upload via the CID the user knows it by (the source_cid). This is not necessarily our normalized v1 CID.
Also the upload listing does not list normalized CIDs so for anyone uploading or pinning v0 CIDs they'll not be able to update their upload (see here).
There was a problem hiding this comment.
I changed this to source_id, @alanshaw does this handle the case of v0 CID's? Is there special precautions or exceptions to make for v0 I need to write?
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been using ID but id is not accurate, content_cid is the id that relates nft uploads to uploads.