Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify CAR blocks with all supported hashes #2460

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Oct 2, 2023

Adds the verifier library so that CARs with blocks that are hashed with a supported hasher other than sha2-256 are also verified.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81ca8bc
Status: ✅  Deploy successful!
Preview URL: https://4494fe5f.nft-storage-1at.pages.dev
Branch Preview URL: https://fix-verify-car-blocks.nft-storage-1at.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #2460 (573815e) into main (bcc90dd) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head 573815e differs from pull request most recent head 81ca8bc. Consider uploading reports for the commit 81ca8bc to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##              main     #2460   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         1303      1324   +21     
=========================================
+ Hits          1303      1324   +21     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alanshaw alanshaw requested a review from olizilla October 2, 2023 11:31
@alanshaw alanshaw merged commit 4526369 into main Oct 11, 2023
20 checks passed
@alanshaw alanshaw deleted the fix/verify-car-blocks branch October 11, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants