Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add count to list nfts api #2701

Merged
merged 1 commit into from
Jul 1, 2024
Merged

feat(api): add count to list nfts api #2701

merged 1 commit into from
Jul 1, 2024

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Jun 29, 2024 •
edited
Loading

Goals

You can't display a progress bar if you don't know what you're progressing toward :)

Implementation

Essentially, use the count feature for posgrest-js that is used in web3.storage old

  • add to count db.listUploads feature, which changes return type
  • modify JSONResponse to actually allow passing headers
  • update tests, though I wasn't able to run them cause mysterious connection refusal errors with my docker setup. but I think I got them passing here

@hannahhoward hannahhoward changed the title Add count to list nfts api feat(api): add count to list nfts api Jun 29, 2024
@hannahhoward hannahhoward marked this pull request as ready for review June 29, 2024 06:10
@alanshaw alanshaw merged commit 6da5098 into nftstorage:main Jul 1, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
alanshaw pushed a commit that referenced this pull request Jul 1, 2024
@github-actions
chore(main): release api 4.9.0 (#2702)
e3f7a48 
🤖 I have created a release *beep* *boop*
---


##
[4.9.0](api-v4.8.1...api-v4.9.0)
(2024-07-01)


### Features

* **api:** add count to list nfts api
([#2701](#2701))
([6da5098](6da5098))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @alanshaw