feat: api get from bucket #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c8819bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74336d64.nftstorage-link.pages.dev |
| Branch Preview URL: | https://feat-api-get-from-bucket.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
5 times, most recently
from
55dd335
to
442f822
Compare
2 tasks
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
from
442f822
to
342ebe6
Compare
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
from
342ebe6
to
d84e893
Compare
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
2 times, most recently
from
ecbffd3
to
77fe24b
Compare
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
4 times, most recently
from
5c62b34
to
d098a81
Compare
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
from
d098a81
to
1171068
Compare
olizilla
reviewed
Jul 6, 2022
packages/edge-gateway/wrangler.toml
Outdated
| @@ -64,6 +67,7 @@ kv_namespaces = [{ binding = "DENYLIST", id = "f4eb0eca32e14e28b643604a82e00cb3" | |||
| [env.staging.vars] | |||
| IPFS_GATEWAYS = "[\"https://ipfs.io\", \"https://cf.nftstorage.link\", \"https://pinata.nftstorage.link\"]" | |||
| GATEWAY_HOSTNAME = 'ipfs-staging.nftstorage.link' | |||
| EDGE_GATEWAY_API_URL = 'https://api.nftstorage.link' | |||
There was a problem hiding this comment.
Can we get rid of this? It would be nice not to need this URL to match up with the binding config as it causes an invariant that we humans must ensure we configure correctly. The binding config should be enough.
There was a problem hiding this comment.
Sadly we cannot :( Fetch fails if we do not provide a full URL. We can provide something random like example.com, but feeling like keeping the real URL is better (and also allows future move out of bindings by just changing code from env.API.fetch to fetch)
Co-authored-by: Oli Evans <oli.evans@gmail.com>
vasco-santos
force-pushed
the
feat/api-get-from-bucket
branch
from
ed97be9
to
c8819bb
Compare
This was referenced Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Other notes:
perma-cache/get.jshad handler for GET perma cache list, but given we actually are adding a GET endpoint to get perma-cache content, it does not make sense anymore. Code there moved to list.js file and new handler code is in get.jsNeeds:
Closes #101