feat: full range header support #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/range-header-support
branch
from
f2657ce
to
6a4bdac
Compare
Deploying with
|
| Latest commit: |
bf813c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2c2178e.nftstorage-link.pages.dev |
| Branch Preview URL: | https://feat-range-header-support.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
feat/range-header-support
branch
from
6a4bdac
to
dc18d81
Compare
alanshaw
requested changes
Jun 16, 2022
packages/api/src/perma-cache/get.js
Outdated
| if (r2Object) { | ||
| return new Response(r2Object.body) | ||
| return new Response(r2Object.body, { |
There was a problem hiding this comment.
Needs Content-Range header e.g. https://github.com/nftstorage/dagcargo-bucket/blob/899070ab67ed2fd39cd1c2f02aad299a179af7e9/src/worker.js#L58
Needs Content-Length header e.g. https://github.com/nftstorage/dagcargo-bucket/blob/899070ab67ed2fd39cd1c2f02aad299a179af7e9/src/worker.js#L59
packages/api/src/perma-cache/get.js
Outdated
| const parts = encoded.split('bytes=')[1]?.split('-') ?? [] | ||
| if (parts.length !== 2) { | ||
| throw new InvalidRangeError( | ||
| 'Not supported to skip specifying the beginning/ending byte at this time' |
There was a problem hiding this comment.
Can maybe use this: https://github.com/nftstorage/dagcargo-bucket/blob/main/src/r2.js
vasco-santos
force-pushed
the
feat/range-header-support
branch
from
dc18d81
to
906b537
Compare
vasco-santos
force-pushed
the
feat/range-header-support
branch
2 times, most recently
from
5cd00ff
to
44eb2ab
Compare
vasco-santos
force-pushed
the
feat/range-header-support
branch
3 times, most recently
from
dedae51
to
ab25929
Compare
vasco-santos
commented
Jun 30, 2022
| [cache.match(request.url), getFromPermaCache(request, env)], | ||
| [ | ||
| cache.match(request), // Request from cache API | ||
| cache.match(request.url), // Request URL from cache API - To be deprecated |
There was a problem hiding this comment.
we need to have this for sometime until cache LRU cycles. Let's say 24H?
vasco-santos
force-pushed
the
feat/range-header-support
branch
from
ab25929
to
c11d12d
Compare
vasco-santos
force-pushed
the
feat/range-header-support
branch
from
c11d12d
to
bf813c4
Compare
vasco-santos
changed the title
This was referenced Jul 25, 2022
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds range header support to both content requested to Cache API, as well as from perma cache. The headers already go to the race as well, so race already does range
Needs:
Closes #77