fix: gateway use cf dns to prevent rate limit instead of durable object #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
50af45c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98643b17.nftstorage-link.pages.dev |
|
Note: there is currently an error "CNAME cross-user banned". This error happens when we attempt to CNAME to a Cloudflare proxied site. We will need to talk with Pinata to have our domain whitelisted |
This was arranged with Pinata team and we are now live 🎉 https://pinata.nftstorage.link/ipfs/bafybeiegsdpbk5bs73mtsj2cduyaq3hddra5c33t6vw2vcctxhhxmsd46u |
olizilla
suggested changes
Apr 25, 2022
Co-authored-by: Oli Evans <oli.evans@gmail.com>
olizilla
approved these changes
Apr 25, 2022
vasco-santos
deleted the
fix/gateway-use-cf-dns-to-prevent-rate-limit-instead-of-do
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Cloudflare durable limits that lead to temporary fix on #32 , this PR adds solution proposed in #17 by replacing Durable Object logic to prevent rate limits by a DNS based solution that enables us to rely on CF dashboard to stipulate rate limits.
Added rate limit rule https://dash.cloudflare.com/fffa4b4363a7e5250af8357087263b3a/nftstorage.link/security/waf/rate-limiting-rules
pinata.nftstorage.link by X-Forwarded-For. Internally within the worker, we track 429 errors already and wey will be counted in metrics.TODO:
Closes #17