fix: api permacache validate content length header #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
e17f833
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3328f0d.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
fix/api-permacache-post-validate-content-length-header
branch
from
b893863
to
37aa131
Compare
lidel
reviewed
May 19, 2022
Comment on lines
+115
to
+113
| // Content length is mandatory given R2 needs a known size of the readable stream | ||
| // TODO: We need public gateways to set content-length for JSON content (maybe others) | ||
| // https://github.com/protocol/bifrost-infra/issues/1868 |
There was a problem hiding this comment.
thanks @lidel ❤️
vasco-santos
force-pushed
the
fix/api-permacache-post-validate-content-length-header
branch
from
37aa131
to
c42e537
Compare
|
We decided to move forward with this solution for MVP until we have a way of buffering content in external service or a fix to get content length here. |
alanshaw
approved these changes
May 20, 2022
vasco-santos
deleted the
fix/api-permacache-post-validate-content-length-header
branch
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Validates content length exists on response from gateway, given it is required by R2. If there is no content length, buffers it in memory and adds to R2 the new Response to get the content length
Related to https://github.com/protocol/bifrost-infra/issues/1868
TODO: