weblate: sync module as far as possible with NixOS PR #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NixOS/nixpkgs#325541 got merged, so as soon as the change lands in nixos-unstable (https://nixpk.gs/pr-tracker.html?pr=325541), I'd say we abandon the poetry2nix based package here and just use the NixOS one. And as soon as NixOS 24.11 is released, this module would need to be deprecated/removed. |
fricklerhandwerk
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to my parallel work on bringing Weblate into NgiPkgs Nixpkgs, I made a lot of improvement that only applied to my Nixpkgs PR. Here I try to sync these back as best as possible, as the Nixpkgs PR seems to be close to mergeable.