Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates NAP receivers when NAP directives are deleted #940

Open
wants to merge 5 commits into
base: poc-v3-otel-syslog
Choose a base branch
from
Open

Updates NAP receivers when NAP directives are deleted #940

wants to merge 5 commits into from

Conversation

RRashmit
Copy link

@RRashmit RRashmit commented Dec 3, 2024 •
edited by dhurley
Loading

Proposed changes

Updates NAP receivers when NAP directives are deleted.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@RRashmit RRashmit requested a review from a team as a code owner December 3, 2024 07:02
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 3, 2024
@RRashmit RRashmit added the v3.x Issues and Pull Requests related to the major version v3 label Dec 3, 2024
@RRashmit RRashmit requested a review from a team December 5, 2024 06:57
@dhurley dhurley changed the title Updates nap receivers when nap directives are deleted Updates NAP receivers when NAP directives are deleted Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-breen sean-breen sean-breen approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RRashmit @oliveromahony @dhurley @sean-breen