Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to Agent Configuration #945

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from
Open

Add labels to Agent Configuration #945

wants to merge 3 commits into from
+518 −2

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Add labels to Agent Configuration

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 12, 2024
@oliveromahony oliveromahony marked this pull request as ready for review December 12, 2024 14:34
@oliveromahony oliveromahony requested a review from a team as a code owner December 12, 2024 14:34
dhurley
dhurley approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there is a separate PR to populate the labels in the AgentConfig proto message?
https://github.com/nginx/agent/blob/v3/internal/watcher/instance/instance_watcher_service.go#L301

@oliveromahony oliveromahony added the v3.x Issues and Pull Requests related to the major version v3 label Dec 16, 2024
@oliveromahony oliveromahony self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@oliveromahony oliveromahony

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliveromahony @dhurley