Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RegExp.prototype[@@replace](). #716

Merged
merged 1 commit into from
May 29, 2024

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented May 28, 2024

With replacement containing "$'", "$`" and Unicode characters.

The similar issue was fixed for String.prototype.replace() in 10127d70e941 (0.7.11).

Found by OSS-Fuzz.

@xeioex xeioex requested a review from VadimZhestikov May 28, 2024 22:37
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex force-pushed the fix-regexp-replace-unicode branch from 9dda689 to 7f92c4d Compare May 28, 2024 22:54
With replacement containing "$'", "$\`" and Unicode characters.

The similar issue was fixed for String.prototype.replace() in
10127d70e941 (0.7.11).

Found by OSS-Fuzz.
@xeioex xeioex force-pushed the fix-regexp-replace-unicode branch from 7f92c4d to c94f7d9 Compare May 28, 2024 23:59
@xeioex xeioex merged commit 532d583 into nginx:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants