Atomic keys introduction for strings, symbols, small numbers. #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimZhestikov
force-pushed
the
atomic_strings
branch
from
45f7a53 to
b5aa2dc
Compare
xeioex
reviewed
Sep 4, 2024
xeioex
requested changes
Sep 4, 2024
VadimZhestikov
force-pushed
the
atomic_strings
branch
2 times, most recently
from
733208d to
1eb9e74
Compare
xeioex
requested changes
Sep 4, 2024
VadimZhestikov
force-pushed
the
atomic_strings
branch
from
1eb9e74 to
8d6cbd8
Compare
|
I'll squash 'Macro NJS_DECLARE_PROP_HANDLER is used for Uint8ClampedArray.' later. |
VadimZhestikov
force-pushed
the
atomic_strings
branch
from
8e6b271 to
bcaad1f
Compare
To have enough space in njs_value_t this patch removed built-in short string. The short strings were an optimization which will be less useful when atomic strings are introduced.
VadimZhestikov
force-pushed
the
atomic_strings
branch
from
bcaad1f to
b84423a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is series of commits which introduce internal atomic representation for
strings, symbols and small numbers as keys for access object properties.
These commits are intended to speed up access to object properties.
Step 1:
Remove long strings from njs core to simplify code and make it more regular.
Reserve atom_id field in njs_value_t.
Notes:
a) Each commit is fully and successfully tested for regressions with all local tests;
b) This PR is draft for internal review, I'll extend it by additional commits as
they will be merged here from my hg sandbox.
c) As soon as last commit will be added/reviewed, draft status from this PR can be removed,
and PR applied then.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument