Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: fixed buffered output. #822

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Nov 26, 2024

No description provided.

@xeioex xeioex marked this pull request as draft November 26, 2024 05:44
@xeioex xeioex force-pushed the fix_buffered_output branch from 13a79fc to 5175b35 Compare November 26, 2024 07:24
Previously, when r.return(code, body) was called from a subrequest
handler with a body size larger than the sendfile_max_chunk value
connection hanging might occur.
@xeioex xeioex force-pushed the fix_buffered_output branch from 5175b35 to 313c46c Compare November 26, 2024 07:33
@mrajagopal
Copy link

I built NJS master + patch and tested it on nginx version: nginx/1.25.5 (nginx-plus-r32-p1).
I can confirm that the patch addresses the issue that initially identified this bug.

@xeioex xeioex marked this pull request as ready for review November 27, 2024 05:27
@xeioex xeioex merged commit b300a93 into nginx:master Nov 27, 2024
1 check passed
@xeioex xeioex deleted the fix_buffered_output branch November 27, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants