Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.34 prep #185

Merged
merged 5 commits into from
Dec 19, 2024
Merged

1.34 prep #185

merged 5 commits into from
Dec 19, 2024

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Dec 17, 2024

1.34.0 release

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/unit/185/

@ac000 ac000 force-pushed the 1.34-prep branch 5 times, most recently from 9d81156 to 53e8d15 Compare December 19, 2024 13:41
@ac000 ac000 marked this pull request as ready for review December 19, 2024 13:46
Copy link
Collaborator

@Jcahilltorre Jcahilltorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestions

Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
This is for OpenTelemetry (OTEL).

Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
@ac000
Copy link
Member Author

ac000 commented Dec 19, 2024

Adress review feedback.

$ git range-diff 53e8d15...1746fab
1:  f5d3062 ! 1:  cbba246 configuration: Add section regarding JSON formatted access logs
    @@ source/configuration/index.rst: to define the log format:
     +===============
     +
     +Starting with NGINX Unit 1.34.0, **format** can instead be an object
    -+describing JSON field name/value pairs, e.g.,
    ++describing JSON field name/value pairs, for example,
     +
     +.. code-block:: json
     +
    @@ source/configuration/index.rst: to define the log format:
     +      }
     +  }
     +
    -+The JSON *values* support being strings, variables and JavaScript.
    ++The JSON *values* can be strings, variables and JavaScript.
      
      ======================
      Conditional access log
2:  2650c94 = 2:  2a3ffac configuration: Add settings/telemetry section
3:  9b64fd5 ! 3:  1a33511 Add 1.34.0 release page
    @@ source/news/2024/unit-1.34.0-released.rst (new)
     +
     +  The endpoint for the OpenTelemetry (OTEL) Collector. This is required.
     +
    -+  It takes a URL to either a gRPC or HTTP endpoint.
    ++  The value must be a URL to either a gRPC or HTTP endpoint.
     +
     +* **protocol**
     +
    @@ source/news/2024/unit-1.34.0-released.rst (new)
     +
     +* The Perl language module no longer adds a 'new' constructor to parsed
     +  scripts. It's not required and could interfere with scripts that were
    -+  trying to use 'new' themselves...
    ++  trying to use 'new' themselves.
     +
     +**********************
     +Changes for developers
    @@ source/news/2024/unit-1.34.0-released.rst (new)
     +  platform).
     +
     +  This is also a first step in getting rid of (mostly at least) our usage of
    -+  u_char and using char instead, which better aligns with libc interfaces etc.
    ++  u_char and using char instead, which better aligns with libc interfaces and
    ++  so on.
     +
     +**************
     +Full Changelog
4:  7eeae75 = 4:  f309118 Update CHANGES.txt for 1.34.0
5:  53e8d15 = 5:  1746fab conf.py: Update for 1.34.0

@ac000
Copy link
Member Author

ac000 commented Dec 19, 2024

I'll await the packages before merging this and sending out the announce email...

@ac000 ac000 merged commit 1746fab into main Dec 19, 2024
2 checks passed
@ac000 ac000 deleted the 1.34-prep branch December 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants