Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine: check if length of $tempDir is non-zero. #836

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

thresheek
Copy link
Collaborator

Fixes #835.

Proposed changes

Previous to this change, $tempDir would fail to be removed since it's a directory and not a file.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@thresheek
Copy link
Collaborator Author

Alpine tests currently fail due to wget 403 on github.com: https://github.com/orgs/community/discussions/65227

@thresheek thresheek merged commit 4b0d808 into nginxinc:master Aug 28, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx 1.25.2 on alpine - docker image oversize
1 participant