Add command line argument to manually disable IPV6 listeners for unsupported clusters #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
haywoodsh
force-pushed
the
feat/option-disabling-ipv6
branch
3 times, most recently
from
1a7fba6 to
1b6fa61
Compare
ciarams87
reviewed
Sep 20, 2022
| @@ -243,6 +243,7 @@ Parameter | Description | Default | |||
| `controller.enableLatencyMetrics` | Enable collection of latency metrics for upstreams. Requires `prometheus.create`. | false | |||
| `controller.minReadySeconds` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | |||
| `controller.strategy` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | |||
| `controller.disableIPV6` | Disable IPV6 listeners explicitly for nodes that do not support the IPV6 stack. | false | |||
There was a problem hiding this comment.
This entry needs to go into docs/content/installation/installation-with-helm.md also
There was a problem hiding this comment.
Documentation updated.
ciarams87
reviewed
Sep 20, 2022
Comment on lines
5
to
6
| {{if $upstream.LBMethod }}{{$upstream.LBMethod}};{{end}} | ||
| {{range $server := $upstream.UpstreamServers}} |
There was a problem hiding this comment.
Why is this indentation being changed? It was correct the way it was (it should be inline with the upstream block opened on line 3)
There was a problem hiding this comment.
This was caused by the linter in my IDE. Will revert the change.
ciarams87
reviewed
Sep 20, 2022
Comment on lines
5
to
9
| {{ if $u.LoadBalancingMethod }} | ||
| {{ $u.LoadBalancingMethod }}; | ||
| {{ end }} | ||
|
|
||
| {{ range $s := $u.Servers }} | ||
| {{ range $s := $u.Servers }} |
There was a problem hiding this comment.
Same comment as above - this indentation should not be changed.
ciarams87
reviewed
Sep 20, 2022
Comment on lines
5
to
11
| {{ if $u.LoadBalancingMethod }} | ||
| {{ $u.LoadBalancingMethod }}; | ||
| {{ end }} | ||
|
|
||
| {{ range $s := $u.Servers }} | ||
| {{ range $s := $u.Servers }} | ||
| server {{ $s.Address }} max_fails={{ $s.MaxFails }} fail_timeout={{ $s.FailTimeout }} max_conns={{ $s.MaxConnections }}; | ||
| {{ end }} | ||
| {{ end }} |
haywoodsh
force-pushed
the
feat/option-disabling-ipv6
branch
from
1b6fa61 to
e99b551
Compare
Codecov Report
@@ Coverage Diff @@
## main #3040 +/- ##
==========================================
- Coverage 52.31% 52.31% -0.01%
==========================================
Files 58 58
Lines 15995 16006 +11
==========================================
+ Hits 8368 8373 +5
- Misses 7350 7356 +6
Partials 277 277
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
haywoodsh
force-pushed
the
feat/option-disabling-ipv6
branch
from
e99b551 to
ad42eb5
Compare
haywoodsh
force-pushed
the
feat/option-disabling-ipv6
branch
from
ad42eb5 to
2fc0064
Compare
haywoodsh
force-pushed
the
feat/option-disabling-ipv6
branch
from
a8eab57 to
23ee4e5
Compare
ciarams87
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add command line argument to manually disable IPV6 listeners for clusters that support IPV4 only.
Checklist
Before creating a PR, run through this checklist and mark each as complete.