Verify reloads & cache secrets #380
Merged
+324
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2018 12:44
Querying the api for secrets here significantly slows down the creation of ingress objects. In most cases we will already have the secret in a store.
- Write config version directly in nginx config - Check config version by querying over socket - Add config version check to API - Atomic write (write and rename) for version config
isaachawley
added
bug
isaachawley
requested review from
peterkellydev,
pleshakov and
Dean-Coakley
pleshakov
approved these changes
Sep 28, 2018
| if err != nil { | ||
| glog.Fatalf("Failed to write to %v: %v", filename, err) | ||
| } | ||
| w.Close() |
There was a problem hiding this comment.
@isaachawley should you not defer right after os.Create above?
There was a problem hiding this comment.
Hmm. We don't normally do that. See writing secrets here. I'm open to changing it but I'd like to change them all at once.
peterkellydev
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
nginx -s reloadblock until we verify that the new config has been loaded.nginx -t, since it's done bynginx -s reload.Reload performance is worse after this change since we block after reloading. However with the secrets cache fix overall performance is improved.
Checklist