Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lb-method validation #439

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix lb-method validation #439

merged 1 commit into from
Nov 16, 2018

Conversation

Dean-Coakley
Copy link
Contributor

Bug description

lb-method and nginx.org/lb-method currently allow the following invalid values: "least_time" and "last_byte".

Proposed changes

  • "least_time" and "last_byte" are no longer valid input
  • Add the above as invalid input to unit test

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Nov 13, 2018
@Dean-Coakley Dean-Coakley self-assigned this Nov 13, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
Bug introduced in: 547055c

* "least_time" and "last_byte" are no longer valid input
* Add the above as invalid input to unit test
@Dean-Coakley Dean-Coakley force-pushed the fix-lbmethod-validation branch from 7113453 to 33107d2 Compare November 16, 2018 17:30
@Dean-Coakley Dean-Coakley merged commit d5178cd into master Nov 16, 2018
@Dean-Coakley Dean-Coakley deleted the fix-lbmethod-validation branch November 16, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants