Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configmap keys #511

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add configmap keys #511

merged 1 commit into from
Mar 15, 2019

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Add new configmap keys:

  • keepalive-timeout
  • keepalive-requests
  • access-log-off

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master

@pleshakov
Add configmap keys
9ee24df 
Add new configmap keys:
- keepalive-timeout
- keepalive-requests
- access-log-off
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Mar 15, 2019
@pleshakov pleshakov requested review from Rulox and Dean-Coakley March 15, 2019 10:37
@pleshakov pleshakov merged commit 07bb0fb into master Mar 15, 2019
@pleshakov pleshakov deleted the configmap-keys branch March 15, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@Rulox Rulox Rulox approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @Rulox @Dean-Coakley