Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security monitoring docs #5301

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Security monitoring docs #5301

merged 10 commits into from
Mar 22, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Mar 22, 2024 •
edited
Loading

Proposed changes

Doc describing how to connect agent to security monitoring.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 22, 2024
@oseoin @j1m-ryan
Update docs/content/tutorials/security-monitoring.md
01ae076 
Co-authored-by: Jim Ryan <j.ryan@f5.com>
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
@oseoin oseoin marked this pull request as ready for review March 22, 2024 13:47
@oseoin oseoin requested review from a team as code owners March 22, 2024 13:47
ADubhlaoich
ADubhlaoich approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, left some edit suggestions.

docs/content/tutorials/security-monitoring.md Outdated Show resolved Hide resolved
docs/content/tutorials/security-monitoring.md Outdated Show resolved Hide resolved
docs/content/tutorials/security-monitoring.md Outdated Show resolved Hide resolved
docs/content/tutorials/security-monitoring.md Outdated Show resolved Hide resolved
@oseoin @ADubhlaoich
Apply suggestions from code review
caa68d8 
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
@oseoin oseoin enabled auto-merge (squash) March 22, 2024 15:49
@oseoin oseoin disabled auto-merge March 22, 2024 16:28
@oseoin
Update security-monitoring.md
3ec67d8 
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
@oseoin oseoin enabled auto-merge (squash) March 22, 2024 16:32
@oseoin oseoin merged commit b1ce3fa into main Mar 22, 2024
49 checks passed
@oseoin oseoin deleted the security-monitoring-docs branch March 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 left review comments

@jjngx jjngx jjngx approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oseoin @ADubhlaoich @j1m-ryan @jjngx @pdabelf5