Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for ProxySetHeaders Annotation #5431

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Apr 19, 2024

Proposed changes

Adds examples for both standard and mergeable ingress for the ProxySetHeaders Annotation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners April 19, 2024 12:35
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 19, 2024
@AlexFenlon
Copy link
Contributor Author

@ADubhlaoich I added link to the examples here but I am not sure if it is correct, would the relative path be better instead of the full link?

@vepatel vepatel requested a review from ADubhlaoich April 19, 2024 13:25
@AlexFenlon AlexFenlon changed the title Add examples & tutorial for ProxySetHeaders Annotation Add examples for ProxySetHeaders Annotation Apr 26, 2024
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon enabled auto-merge (squash) April 26, 2024 15:25
@AlexFenlon AlexFenlon merged commit 4a3150c into main Apr 26, 2024
26 checks passed
@AlexFenlon AlexFenlon deleted the docs/proxy-set-headers-annotation-examples branch April 26, 2024 15:25
@AlexFenlon AlexFenlon self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants