Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for replaceAll #5481

Merged
merged 2 commits into from
May 1, 2024
Merged

Add unit tests for replaceAll #5481

merged 2 commits into from
May 1, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 1, 2024 •
edited
Loading

Proposed changes

  • Add unit tests for replaceAll added in 7f19bed

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from haywoodsh and j1m-ryan May 1, 2024 11:39
@vepatel vepatel requested a review from a team as a code owner May 1, 2024 11:39
@github-actions github-actions bot added the go Pull requests that update Go code label May 1, 2024
@vepatel vepatel enabled auto-merge (squash) May 1, 2024 11:43
@vepatel vepatel merged commit 3ce86ae into main May 1, 2024
50 checks passed
@vepatel vepatel deleted the chore/add-unit-tests-replaceAll branch May 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @haywoodsh @j1m-ryan