Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cert-gen script #5583

Merged
merged 3 commits into from
May 20, 2024
Merged

remove cert-gen script #5583

merged 3 commits into from
May 20, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 20, 2024 •
edited
Loading

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 20, 2024 10:21
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 20, 2024
@vepatel vepatel requested a review from a team as a code owner May 20, 2024 10:25
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 20, 2024
@vepatel vepatel enabled auto-merge (squash) May 20, 2024 10:41
@vepatel vepatel merged commit 39b6695 into main May 20, 2024
50 checks passed
@vepatel vepatel deleted the chore/remove-cert-gen branch May 20, 2024 11:09
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@vepatel @ssrahul96
remove cert-gen script (nginxinc#5583)
6ad91bd
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @oseoin @jjngx @pdabelf5