-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make access_log in http context configurable #5648
Conversation
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc change LGTM!
17afc1d
to
eeab436
Compare
Hi @hafe , could you please update the conflicting files? |
eeab436
to
65424e7
Compare
@hafe , could you please |
d595b46
to
12d31cb
Compare
8de4bf3
to
f79cf78
Compare
f79cf78
to
e2fa62b
Compare
docs/content/configuration/global-configuration/configmap-resource.md
Outdated
Show resolved
Hide resolved
5613cfe
to
df9d363
Compare
5cdff87
to
ec84dc1
Compare
@hafe could you please update the branch? I am reviewing changes atm. |
You mean just rebase it from main? |
Yes, please rebase. |
ec84dc1
to
52f063f
Compare
@hafe thank you again for contributing. I've tested the feature and confirm it works as expected. input data: kind: ConfigMap
apiVersion: v1
metadata:
name: nginx-config
namespace: nginx-ingress
data:
access-log: "yslog:server=localhost:514"
access-log-off: "false" will results with: kind: ConfigMap
apiVersion: v1
metadata:
name: nginx-config
namespace: nginx-ingress
data:
access-log: "syslog:server=localhost:514"
access-log-off: "false" will results with: kind: ConfigMap
apiVersion: v1
metadata:
name: nginx-config
namespace: nginx-ingress
data:
access-log: "syslog:server=localhost:514"
access-log-off: "true" will result with: If a user tries to set a value that is not valid, the log will be set to default one. NIC logs will show the error:
@hafe since the NIC does not handle warnings in case of invalid Handling the error event will likely be a separate PR. |
I can do that. It should really be a warning log also |
52f063f
to
59a5665
Compare
@hafe could you please also update template tests? |
Not sure what you mean by that |
could you run |
No nothing changes. |
Ok, I will check what is going on with the templates and snapshots, and get back to you ASAP. |
@hafe there is a missing filed After that please update the branch. Once again thank you for contributing! I am hoping to get your PR merged next week. |
Closes nginxinc#5625 Signed-off-by: Hans Feldt <2808287+hafe@users.noreply.github.com>
59a5665
to
eab5e62
Compare
Seems to be OK now after latest updates. Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Closes #5625
Proposed changes
See #5625
Checklist
Before creating a PR, run through this checklist and mark each as complete.