Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to gorelease 2.0 config syntax #5700

Merged
merged 4 commits into from
Jun 6, 2024
Merged

update to gorelease 2.0 config syntax #5700

merged 4 commits into from
Jun 6, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 6, 2024 •
edited
Loading

Proposed changes

GoRelease 2.0 has updated the config file syntax. This change reflects those updates

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 6, 2024 14:03
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 6, 2024
@pdabelf5 pdabelf5 self-assigned this Jun 6, 2024
@pdabelf5 pdabelf5 added the dependencies Pull requests that update a dependency file label Jun 6, 2024
@pdabelf5 pdabelf5 force-pushed the gorelease-config-update branch from 830ea0c to eb4c80b Compare June 6, 2024 14:15
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 6, 2024
@pdabelf5 pdabelf5 force-pushed the gorelease-config-update branch from 187f3f4 to 88c5db6 Compare June 6, 2024 14:17
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Jun 6, 2024
@pdabelf5 pdabelf5 added the dependencies Pull requests that update a dependency file label Jun 6, 2024
@pdabelf5 pdabelf5 merged commit d31458a into main Jun 6, 2024
78 checks passed
@pdabelf5 pdabelf5 deleted the gorelease-config-update branch June 6, 2024 20:33
nginx-bot pushed a commit that referenced this pull request Jun 6, 2024
@pdabelf5 @web-flow
update to gorelease 2.0 config syntax (#5700)
890ddf3
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@pdabelf5 @ssrahul96
update to gorelease 2.0 config syntax (nginxinc#5700)
a3bed6d
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

@oseoin oseoin oseoin approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @oseoin @vepatel @AlexFenlon @jjngx