Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default telemetry endpoint #5885

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Add default telemetry endpoint #5885

merged 4 commits into from
Jun 28, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jun 28, 2024 •
edited
Loading

Proposed changes

Set default telemetry reporting endpoint

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Jun 28, 2024
@shaun-nx shaun-nx marked this pull request as ready for review June 28, 2024 11:49
@shaun-nx shaun-nx requested a review from a team as a code owner June 28, 2024 11:49
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Jun 28, 2024
jjngx
jjngx reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to check the value of the endpoint var in the main func (around line L189, before creating lbcInput struct) and assign the default endpoint value?

@shaun-nx shaun-nx enabled auto-merge (squash) June 28, 2024 13:32
@shaun-nx shaun-nx merged commit 77cc604 into main Jun 28, 2024
84 checks passed
@shaun-nx shaun-nx deleted the fix/telemetry-endpoint branch June 28, 2024 14:06
nginx-bot pushed a commit that referenced this pull request Jun 28, 2024
@shaun-nx @web-flow
Add default telemetry endpoint (#5885)
67566f7
@shaun-nx shaun-nx added this to the v3.6.1 milestone Jun 28, 2024
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@shaun-nx @AlexFenlon
Add default telemetry endpoint (#5885)
baf0a81
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx left review comments

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@shaun-nx @oseoin @j1m-ryan @vepatel @jjngx