Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support End Session Endpoint for OIDC and allow customizable Post-logout Redirect URI #6092

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Support End Session Endpoint for OIDC and allow customizable Post-logout Redirect URI #6092

merged 10 commits into from
Aug 7, 2024

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jul 30, 2024 •
edited
Loading

Proposed changes

Support End Session Endpoint for OIDC and allow customizable Post-Logout Redirect URI. Post-Logout redirect URI can only be set when End Session Endpoint is present.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels Jul 30, 2024
@haywoodsh haywoodsh force-pushed the feat/oidc-logout branch 2 times, most recently from 7acc08f to 3a0e71d Compare August 1, 2024 11:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6092/

@haywoodsh haywoodsh force-pushed the feat/oidc-logout branch 4 times, most recently from c4120f0 to af8ce33 Compare August 2, 2024 11:55
@haywoodsh haywoodsh changed the title Support Logout Endpoint for OIDC and allow customisable Post-logout Redirect URI Support End Session Endpoint for OIDC and allow customizable Post-logout Redirect URI Aug 2, 2024
@haywoodsh haywoodsh marked this pull request as ready for review August 2, 2024 15:42
@haywoodsh haywoodsh requested review from a team as code owners August 2, 2024 15:42
ADubhlaoich
ADubhlaoich approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes LGTM.

haywoodsh and others added 8 commits August 6, 2024 13:35
@haywoodsh
Support Logout Endpoint for OIDC and allow customisable Post-logout R…
175ae56 
…edirect URI

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
update example
d306d05 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
fix indentation
47609aa 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@pre-commit-ci @haywoodsh
[pre-commit.ci] auto fixes from pre-commit.com hooks
321ccd7 
for more information, see https://pre-commit.ci
@haywoodsh
rename field
466b7fc 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
rename logout redirect
493c49b 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
fix docs and test messages
2e30079 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
update test field values
50e8fd5 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh linked an issue Aug 6, 2024 that may be closed by this pull request
Be logged out on IDP side #4989
Closed
jjngx
jjngx approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@haywoodsh haywoodsh merged commit 06b9507 into main Aug 7, 2024
79 checks passed
@haywoodsh haywoodsh deleted the feat/oidc-logout branch August 7, 2024 11:52
@pdabelf5 pdabelf5 mentioned this pull request Aug 13, 2024
Open
@llomgui
Copy link

llomgui commented Oct 10, 2024

Hi,

First, thank you for adding these changes in the latest release.
I am a bit confused of not being mentionned due to my previous PR https://github.com/nginxinc/kubernetes-ingress/pull/4986/files. This PR and mine look almost the same.

@vepatel
Copy link
Contributor

vepatel commented Oct 14, 2024 •
edited
Loading

Hi @llomgui, I've added you to the release page and will update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be logged out on IDP side
7 participants
@haywoodsh @llomgui @vepatel @ADubhlaoich @AlexFenlon @jjngx @pdabelf5