Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-order mounting debian apt source file #6223

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 16, 2024

Proposed changes

Avoid certificate warning when building the Debian plus images. Move debian apt source file to be used when gpg keys are armoured.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 16, 2024 09:37
@github-actions github-actions bot added the docker Pull requests that update Docker code label Aug 16, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.86%. Comparing base (491e68e) to head (55af6cc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6223      +/-   ##
==========================================
+ Coverage   45.58%   45.86%   +0.27%     
==========================================
  Files         142      142              
  Lines       18961    18961              
==========================================
+ Hits         8644     8696      +52     
+ Misses       9868     9818      -50     
+ Partials      449      447       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit c5c5883 into main Aug 16, 2024
78 checks passed
@pdabelf5 pdabelf5 deleted the debian-build-warning branch August 16, 2024 10:57
@vepatel vepatel mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants