Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable batch reload when batch finishes #6446

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Disable batch reload when batch finishes #6446

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a64c1a
fix: disable batch reload when batch finishes
dareste Sep 17, 2024
2f27ad8
Merge branch 'main' into fix-batch-reload
dareste Sep 18, 2024
44a2f29
Merge branch 'main' into fix-batch-reload
jjngx Sep 20, 2024
1bd0bea
Merge branch 'main' into fix-batch-reload
jjngx Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/k8s/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@
defer lbc.syncLock.Unlock()
}
if lbc.batchSyncEnabled && task.Kind != endpointslice {
glog.V(3).Infof("Task is not endpointslice - enabling batch reload")

Check warning on line 919 in internal/k8s/controller.go

View check run for this annotation

Codecov / codecov/patch

internal/k8s/controller.go#L919 

Added line #L919 was not covered by tests
lbc.enableBatchReload = true
}
switch task.Kind {
Expand All @@ -931,6 +932,7 @@
case endpointslice:
resourcesFound := lbc.syncEndpointSlices(task)
if lbc.batchSyncEnabled && resourcesFound {
glog.V(3).Infof("Endpointslice %v is referenced - enabling batch reload", task.Key)

Check warning on line 935 in internal/k8s/controller.go

View check run for this annotation

Codecov / codecov/patch

internal/k8s/controller.go#L935 

Added line #L935 was not covered by tests
lbc.enableBatchReload = true
}
case secret:
Expand Down Expand Up @@ -990,7 +992,8 @@
}
}

glog.V(3).Infof("Batch sync completed")
lbc.enableBatchReload = false
glog.V(3).Infof("Batch sync completed - disabling batch reload")

Check warning on line 996 in internal/k8s/controller.go

View check run for this annotation

Codecov / codecov/patch

internal/k8s/controller.go#L995-L996 

Added lines #L995 - L996 were not covered by tests
}
}

Expand Down
Loading