Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate config to skip v5 tests #6493

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 24, 2024

Proposed changes

  • add separate config to skip v5 tests
===================================================================================== short test summary info =====================================================================================
SKIPPED [2] suite/test_app_protect_wafv5_integration.py:51: Skip AppProtect WAF v5 test in non-AP WAF v5 image
SKIPPED [1] suite/test_app_protect_wafv5_integration.py: Skip AppProtect WAF v5 test in non-AP WAF v5 image
========================================================================= 3 skipped, 537 deselected, 2 warnings in 0.45s ==========================================================================

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 24, 2024 15:00
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 24, 2024
@vepatel vepatel enabled auto-merge (squash) September 24, 2024 15:01
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.22%. Comparing base (217504b) to head (b1327ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6493      +/-   ##
==========================================
+ Coverage   53.21%   53.22%   +0.01%     
==========================================
  Files          85       85              
  Lines       16016    16016              
==========================================
+ Hits         8523     8525       +2     
+ Misses       7085     7083       -2     
  Partials      408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vepatel vepatel merged commit f6afacb into main Sep 24, 2024
89 of 119 checks passed
@vepatel vepatel deleted the tests/fix-regression-job branch September 24, 2024 15:57
@pdabelf5 pdabelf5 removed python Pull requests that update Python code tests Pull requests that update tests labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title add separate config to skip v5 tests Add separate config to skip v5 tests Dec 16, 2024
@pdabelf5 pdabelf5 added the tests Pull requests that update tests label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants