Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana template update that works with grafana v11.2.0 #6511

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

sdutta9
Copy link
Contributor

@sdutta9 sdutta9 commented Sep 25, 2024

Proposed changes

Updates to the grafana template so that Prometheus datasource is templatized to make it work with latest version of grafana(v11.2.0 - grafana helm chart v8.5.1).

Related Discussions: #3032

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sdutta9 sdutta9 requested a review from a team as a code owner September 25, 2024 17:06
Copy link

github-actions bot commented Sep 25, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@sdutta9 sdutta9 changed the title grafana template update that works with grafana v8.5.1 grafana template update that works with grafana v11.2.0 Sep 25, 2024
@sdutta9
Copy link
Contributor Author

sdutta9 commented Sep 25, 2024

I have hereby read the F5 CLA and agree to its terms

@jjngx
Copy link
Contributor

jjngx commented Sep 26, 2024

@sdutta9 could you please add steps how you tested the new configuration?

@sdutta9
Copy link
Contributor Author

sdutta9 commented Sep 26, 2024

@sdutta9 could you please add steps how you tested the new configuration?

Steps to setup

  1. Install latest grafana via helm
     helm install nginx-grafana grafana/grafana --version 8.5.1 -n monitoring
  2. Login to Grafana and add prometheus as your datasource.
  3. In Dashboard pane, click on import dashboard.
  4. Copy the contents of NGINXPlusICDashboard.json in the "Import via dashboard JSON model" box.
  5. Click on "Load" button.
  6. Once you click on "Load" button, it should show name, folder, UID fields pre populated.
  7. Only thing that you need to select from drop down is your prometheus datasource for the prometheus section(See screenshot)
    image
  8. Click on "Import" after selecting your prometheus datasource, to finish the Dashboard import step.

@jjngx jjngx added chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch labels Sep 27, 2024
@jjngx jjngx merged commit ca835f5 into nginxinc:main Sep 27, 2024
68 of 88 checks passed
jjngx added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Shouvik Dutta <shouvik.dutta96@gmail.com>
@sdutta9 sdutta9 deleted the grafana branch September 27, 2024 14:34
@pdabelf5 pdabelf5 changed the title grafana template update that works with grafana v11.2.0 Grafana template update that works with grafana v11.2.0 Dec 13, 2024
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants