Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace glog in global_configuration.go #6563

Merged
merged 22 commits into from
Oct 2, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 2, 2024

Proposed changes

  • remove google/glog from main.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon self-assigned this Oct 2, 2024
@AlexFenlon AlexFenlon requested a review from a team as a code owner October 2, 2024 08:18
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 2, 2024
@AlexFenlon AlexFenlon added the skip changelog Pull requests that don't need to be added to the changelog label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.01%. Comparing base (e750d84) to head (c1242b3).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/global_configuration.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6563      +/-   ##
==========================================
- Coverage   53.08%   53.01%   -0.07%     
==========================================
  Files          87       87              
  Lines       16200    16223      +23     
==========================================
+ Hits         8599     8601       +2     
- Misses       7194     7215      +21     
  Partials      407      407              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexFenlon AlexFenlon mentioned this pull request Oct 2, 2024
16 tasks
@AlexFenlon AlexFenlon enabled auto-merge (squash) October 2, 2024 14:09
@AlexFenlon AlexFenlon merged commit a45b9cb into main Oct 2, 2024
81 checks passed
@AlexFenlon AlexFenlon deleted the chore/refactor-global-config-glog branch October 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants