Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace glog in k8s package 1 #6575

Merged
merged 9 commits into from
Oct 2, 2024
Merged

refactor: replace glog in k8s package 1 #6575

merged 9 commits into from
Oct 2, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 2, 2024

Proposed changes

Replace glog with slog in k8s package for:

  • appprotect_dos.go
  • appprotect_waf.go
  • configmap.go
  • endpoint_slice.go
  • ingress_link.go
  • leader.go
  • handlers.go

NOTE:

GLog Levels Slog Levels
glog.V(3).Infof() log.Debugf()
glog.V(3).Info() log.Debug()
glog.V(2).Infof() log.Debugf()
glog.V(2).Info() log.Debugf()
glog.Infof() log.Infof()
glog.Info() log.Info()
glog.Warningf() log.Warnf()
glog.Warning() log.Warn()
glog.Errorf() log.Errorf()
glog.Error() log.Error()
glog.Fatalf() log.Fatalf()
glog.Fatal() log.Fatal()

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner October 2, 2024 14:40
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 2.38095% with 123 lines in your changes missing coverage. Please review.

Project coverage is 53.07%. Comparing base (e750d84) to head (c2a625f).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/appprotect_waf.go 0.00% 27 Missing ⚠️
internal/k8s/handlers.go 10.00% 27 Missing ⚠️
internal/k8s/appprotect_dos.go 0.00% 23 Missing ⚠️
internal/k8s/ingress_link.go 0.00% 15 Missing ⚠️
internal/k8s/endpoint_slice.go 0.00% 13 Missing ⚠️
internal/k8s/leader.go 0.00% 10 Missing ⚠️
internal/k8s/configmap.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.01%     
==========================================
  Files          87       87              
  Lines       16200    16218      +18     
==========================================
+ Hits         8599     8607       +8     
- Misses       7194     7203       +9     
- Partials      407      408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon merged commit 3f79c6d into main Oct 2, 2024
81 checks passed
@AlexFenlon AlexFenlon deleted the refactor-glog-k8s branch October 2, 2024 15:57
@pdabelf5 pdabelf5 added the skip changelog Pull requests that don't need to be added to the changelog label Oct 2, 2024
@AlexFenlon AlexFenlon mentioned this pull request Oct 2, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants