Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static check action to CI #6649

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Add static check action to CI #6649

merged 4 commits into from
Oct 14, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Adds the static check action to the CI

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Oct 14, 2024
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.30%. Comparing base (d3f1246) to head (f7e3786).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6649      +/-   ##
==========================================
+ Coverage   53.29%   53.30%   +0.01%     
==========================================
  Files          87       87              
  Lines       16277    16281       +4     
==========================================
+ Hits         8675     8679       +4     
- Misses       7187     7189       +2     
+ Partials      415      413       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the go Pull requests that update Go code label Oct 14, 2024
@j1m-ryan j1m-ryan marked this pull request as ready for review October 14, 2024 13:16
@j1m-ryan j1m-ryan requested a review from a team as a code owner October 14, 2024 13:16
@j1m-ryan j1m-ryan enabled auto-merge (squash) October 14, 2024 13:36
@j1m-ryan j1m-ryan merged commit 33dd1f0 into main Oct 14, 2024
79 checks passed
@j1m-ryan j1m-ryan deleted the chore/add-staticcheck-action branch October 14, 2024 13:39
@pdabelf5 pdabelf5 changed the title chore: add static check action to CI Add static check action to CI Dec 16, 2024
@pdabelf5 pdabelf5 removed the github_actions Pull requests that update Github_actions code label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants