Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew expired certificate used in tests #6736

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Renew expired certificate used in tests #6736

merged 1 commit into from
Oct 31, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 30, 2024 •
edited
Loading

Proposed changes

Renew expire virtual-server.example.com certificate

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Oct 30, 2024
@pdabelf5 pdabelf5 self-assigned this Oct 30, 2024
@pdabelf5 pdabelf5 requested a review from a team as a code owner October 30, 2024 16:45
@github-actions github-actions bot added python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks tests Pull requests that update tests labels Oct 30, 2024
@AlexFenlon AlexFenlon merged commit 41d4920 into main Oct 31, 2024
80 checks passed
@AlexFenlon AlexFenlon deleted the cert-fix branch October 31, 2024 09:16
nginx-bot pushed a commit that referenced this pull request Oct 31, 2024
@pdabelf5 @web-flow
renew expired certificate used in tests (#6736)
d8e5134
@pdabelf5 pdabelf5 removed python Pull requests that update Python code github_actions Pull requests that update Github_actions code tests Pull requests that update tests needs cherry pick Cherry pick this PR into a release branch labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title renew expired certificate used in tests Renew expired certificate used in tests Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @j1m-ryan @AlexFenlon @jjngx