Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC fix for ID token nonce claim validation #6760

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add OIDC fix for ID token nonce claim validation #6760

merged 2 commits into from
Nov 6, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Nov 6, 2024

Proposed changes

Fix for OIDC js: ID token nonce claim validation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx added the needs cherry pick Cherry pick this PR into a release branch label Nov 6, 2024
@jjngx jjngx requested a review from a team as a code owner November 6, 2024 15:04
@github-actions github-actions bot added the bug An issue reporting a potential bug label Nov 6, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.36%. Comparing base (1498849) to head (818b3c5).
Report is 99 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6760      +/-   ##
==========================================
- Coverage   53.38%   53.36%   -0.02%     
==========================================
  Files          89       89              
  Lines       20195    20195              
==========================================
- Hits        10781    10777       -4     
- Misses       8977     8979       +2     
- Partials      437      439       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) November 6, 2024 15:31
@pdabelf5 pdabelf5 merged commit b90209f into main Nov 6, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the fix/oidc branch November 6, 2024 15:51
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed bug An issue reporting a potential bug chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants