Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license expiry checks #6917

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Add license expiry checks #6917

merged 3 commits into from
Dec 5, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 4, 2024

Proposed changes

Add license expiry & Usage reporting grace period checks to the license reporter go routine. This change will add events to the Pod if either of the license expiry or the usage reporting grace period are within 30 days.

Adjust the reporting period from 24 hours down to an hour. This is inline with the period the event will appear on the pod.

Requires #6916

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 4, 2024 14:26
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 34.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (39b285d) to head (d950494).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
internal/license_reporting/license_reporting.go 39.53% 26 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 4 Missing ⚠️
internal/nginx/manager.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6917   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files          88       88           
  Lines       20591    20623   +32     
=======================================
+ Hits        10903    10921   +18     
- Misses       9239     9255   +16     
+ Partials      449      447    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pdabelf5 pdabelf5 merged commit df9b043 into main Dec 5, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the update-license-reporting branch December 5, 2024 12:25
@pdabelf5 pdabelf5 changed the title Update license reporting Add license expiry checks Dec 16, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants