Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mgmt configmap tests #6957

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Add mgmt configmap tests #6957

merged 6 commits into from
Dec 12, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

  • Adding mgmt configmap tests
  • Fix bug: at runtime a mgmt ClientAuth cert was in the wrong directory.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan added the bug An issue reporting a potential bug label Dec 11, 2024
@j1m-ryan j1m-ryan requested a review from a team as a code owner December 11, 2024 16:13
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests and removed bug An issue reporting a potential bug labels Dec 11, 2024
@j1m-ryan j1m-ryan added the needs cherry pick Cherry pick this PR into a release branch label Dec 11, 2024
@vepatel vepatel self-requested a review December 11, 2024 16:26
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (025ddd7) to head (093c68d).

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 21 Missing ⚠️
internal/configs/configurator.go 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6957      +/-   ##
==========================================
- Coverage   52.59%   52.52%   -0.07%     
==========================================
  Files          88       88              
  Lines       20789    20803      +14     
==========================================
- Hits        10933    10927       -6     
- Misses       9401     9419      +18     
- Partials      455      457       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) December 12, 2024 09:09
@j1m-ryan j1m-ryan merged commit e127558 into main Dec 12, 2024
30 checks passed
@j1m-ryan j1m-ryan deleted the chore/r33-tests branch December 12, 2024 09:13
nginx-bot pushed a commit that referenced this pull request Dec 12, 2024
* test full mgmt config params

* fix mgmt client auth runtime secret location

* add test for full suit of mgmt configmap params

* update snaps, fix signature in tests

* update snaps
j1m-ryan added a commit that referenced this pull request Dec 12, 2024
Add mgmt configmap tests (#6957)

* test full mgmt config params

* fix mgmt client auth runtime secret location

* add test for full suit of mgmt configmap params

* update snaps, fix signature in tests

* update snaps

Co-authored-by: Jim Ryan <j.ryan@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants