Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow scan uploads to fail #6961

Merged
merged 3 commits into from
Dec 12, 2024
Merged

allow scan uploads to fail #6961

merged 3 commits into from
Dec 12, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 11, 2024

Proposed changes

Allow pipeline to succeed if the sarif upload fails

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 self-assigned this Dec 11, 2024
@pdabelf5 pdabelf5 requested a review from a team as a code owner December 11, 2024 17:25
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Dec 11, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) December 12, 2024 09:35
@pdabelf5 pdabelf5 merged commit 5a2dd49 into main Dec 12, 2024
30 checks passed
@pdabelf5 pdabelf5 deleted the scan-uploads-fail branch December 12, 2024 09:38
pdabelf5 added a commit that referenced this pull request Dec 12, 2024
pdabelf5 added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants