Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mgmt configmap tests #6987

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 13, 2024

Proposed changes

Add further tests to validate parameters passed to the mgmt configmap

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 13, 2024 15:01
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 13, 2024
@pdabelf5 pdabelf5 added tests Pull requests that update tests needs cherry pick Cherry pick this PR into a release branch labels Dec 13, 2024
@github-actions github-actions bot removed the tests Pull requests that update tests label Dec 13, 2024
…xinc/kubernetes-ingress into tests/add-more-mgmt-configmap-tests
@pdabelf5 pdabelf5 changed the title Add more mgmt configmap tests Add additional mgmt configmap tests Dec 13, 2024
@pdabelf5 pdabelf5 changed the title Add additional mgmt configmap tests Expand mgmt configmap tests Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (90c2e8a) to head (d0f1f9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configmaps.go 40.00% 4 Missing and 2 partials ⚠️
internal/validation/validation.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6987      +/-   ##
==========================================
+ Coverage   52.55%   52.73%   +0.17%     
==========================================
  Files          88       89       +1     
  Lines       20803    20824      +21     
==========================================
+ Hits        10933    10981      +48     
+ Misses       9415     9389      -26     
+ Partials      455      454       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) December 16, 2024 12:30
@pdabelf5 pdabelf5 merged commit 6103b0a into main Dec 16, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the tests/add-more-mgmt-configmap-tests branch December 16, 2024 12:56
nginx-bot pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants