-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NodePort and LoadBalancer Service Types for GatewayStatus Addresses field #604
Comments
Note: this is a blocker for external-dns integration (we need the address from the fronting LoadBalancer Service). |
Another note: we set the GatewayStatus to the Pod IP, not the Service's ClusterIP. Should we also support ClusterIP as part of this story? (or maybe not since we'll always use the NodePort or LoadBalancer IP?) |
Service ClusterIP is not appropriate. Since the Gateway is always fronting the service. You got there. |
Do we want to support setting the address to Hostname if available? (https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1beta1/shared_types.go#L719) Or do we only support IP addresses right now? |
I think we also want to support Hostname since some LoadBalancers (like AWS NLB) will be exposed with a dns name instead of an IP address. |
Decided to punt on NodePort support for now: #1142 |
Set the GatewayStatus addresses field based on the type of Service that exposes NKG.
The initial issue for supporting GatewayStatus addresses is limited in scope and will set the GatewayStatus address field to the ClusterIP of the Service, regardless of the Service type.
This issue covers the work to support addresses for LoadBalancer and NodePort Services.
Acceptance
The text was updated successfully, but these errors were encountered: