-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure NGINX reload occurs #1033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
commented
Sep 5, 2023
ciarams87
commented
Sep 5, 2023
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
from
September 6, 2023 11:56
9fe81f4
to
879f921
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 6, 2023
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
from
September 6, 2023 14:14
879f921
to
5643f9f
Compare
sjberman
requested changes
Sep 6, 2023
kate-osborn
requested changes
Sep 6, 2023
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
from
September 7, 2023 15:28
14f7416
to
dcd602b
Compare
kate-osborn
requested changes
Sep 7, 2023
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
from
September 8, 2023 14:14
dcd602b
to
73c5143
Compare
sjberman
reviewed
Sep 8, 2023
bjee19
requested changes
Sep 8, 2023
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
4 times, most recently
from
September 11, 2023 09:31
32c445a
to
77434f4
Compare
sjberman
approved these changes
Sep 11, 2023
bjee19
approved these changes
Sep 11, 2023
kate-osborn
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
ciarams87
force-pushed
the
fix/ensure-reload-happens
branch
from
September 11, 2023 19:19
e776a0c
to
d7b261d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
When we reload NGINX, we do not check whether the reload succeeds. We just sleep for a second to wait for the new workers to spin up. We need to verify that a reload was successful and return an error if it fails.
Solution: First check if NGINX accepted the reload by confirming using the
/proc
filesystem that new workers are being created. Then use a configVersion check to ensure the expected version of the configuration is being served by the workers to confirm the reload was successful.Testing: Manual testing with successful config and incorrect config, added and updated unit-tests, ensured conformance tests still pass
Closes #664
Checklist
Before creating a PR, run through this checklist and mark each as complete.