-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect ClientSettingsPolicy, ObservabilityPolicy, and NginxProxy count #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jun 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
+ Coverage 87.59% 87.62% +0.03%
==========================================
Files 96 96
Lines 6698 6715 +17
Branches 50 50
==========================================
+ Hits 5867 5884 +17
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
bjee19
commented
Jun 27, 2024
sjberman
approved these changes
Jun 28, 2024
In the future, I may consider this a |
kate-osborn
reviewed
Jun 28, 2024
pleshakov
reviewed
Jun 28, 2024
bjee19
changed the title
Collect ClientSettingsPolicy, ObservabilityPolicy, and NGINXProxy count
Collect ClientSettingsPolicy, ObservabilityPolicy, and NginxProxy count
Jun 28, 2024
kate-osborn
approved these changes
Jun 28, 2024
pleshakov
approved these changes
Jun 28, 2024
bjee19
force-pushed
the
enh/collect-policy-count
branch
from
July 8, 2024 21:44
77637c1
to
d02d232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect count for ClientSettingsPolicies attached at the Gateway level, ClientSettingsPolicies attached at the Route level, ObservabilityPolicies, and NginxProxy.
Problem: I want to collect the number of ClientSettings, Observability, and NginxProxy Policies used in NGF for each context they are used in.
Solution: Collect the counts of the resources.
Testing: Manual testing and addition to unit tests.
Output with a Gateway level ClientSettingsPolicy, a Route level ClientSettingsPolicy, an ObservabilityPolicy, and the NGINXProxy attached.
Output with none of the above resources attached:
Closes #1898
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.