-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to provide custom pod annotations #2250
Add possibility to provide custom pod annotations #2250
Conversation
Hi @Robsta86! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
@Robsta86 thanks for the contribution! Can you run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 96 96
Lines 6715 6715
Branches 50 50
=======================================
Hits 5884 5884
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Proposed changes
Problem: Currently the helm chart does not provide an option to configure custom annotations for the nginx-gateway-fabric pod(s). In our scenario this is inconvenient because the pre-configured annotations Prometheus specific, but we are using Grafana Alloy to scrape metrics and Alloy is expecting different annotations. Of course there are also other scenarios where custom annotations can be useful, for instance to configure exceptions for Gatekeeper policies.
Solution: This Pull Request adds the possibility to configure your own custom annotations which will be added to the nginx-gateway-fabric pods.
Testing: Tested by installing the helm chart with the default values, and after that installing the helm chart with custom annotations configured.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.