Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seccompProfile to Helm chart #2323

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: Not specifying the seccompProfile gives warnings in certain environments

Solution: Set the seccompProfile

Closes #2322

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner July 31, 2024 22:55
@github-actions github-actions bot added enhancement New feature or request helm-chart Relates to helm chart labels Jul 31, 2024
@lucacome lucacome force-pushed the enh/seccompProfile branch from 129fdd6 to c7fe645 Compare July 31, 2024 23:03
@sjberman
Copy link
Contributor

sjberman commented Aug 1, 2024

Does the OpenShift SCC need to be updated to support this as well?

Problem: Not specifying the seccompProfile gives warnings in certain
enviroments

Solution: Set the seccompProfile
@lucacome lucacome force-pushed the enh/seccompProfile branch from c7fe645 to 6c8b71f Compare August 1, 2024 20:20
@lucacome
Copy link
Member Author

lucacome commented Aug 1, 2024

@sjberman added to SCC

@lucacome lucacome requested a review from a team August 1, 2024 20:21
@lucacome lucacome merged commit edb9add into nginxinc:main Aug 1, 2024
44 checks passed
@lucacome lucacome deleted the enh/seccompProfile branch August 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add seccompProfile to Helm Chart
3 participants