-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for TLS Route in site #2363
Add guide for TLS Route in site #2363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
- Coverage 88.84% 88.81% -0.03%
==========================================
Files 100 100
Lines 7527 7527
Branches 50 50
==========================================
- Hits 6687 6685 -2
- Misses 784 785 +1
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
We should include something more here to indicate that it's actually working if possible, other than just a response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, generally. See Saylor's feedback about the DOCS code.
My edit suggestions are largely to remove possessive language, which we avoid for tone.
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/tls-passthrough-routing.md
Outdated
Show resolved
Hide resolved
cf570eb
to
7875ca5
Compare
Hi @sarthyparty! Thanks for opening this pull request! |
Problem: Site did not have a guide for TLS Route Solution: I wrote a guide for it.
7875ca5
to
b4689f8
Compare
Co-authored-by: Saylor Berman <s.berman@f5.com>
Co-authored-by: Saylor Berman <s.berman@f5.com>
Problem: No user-facing documentation for configuring TLS Passthrough Solution: Add a how-to guide for TLS Passthrough and update Gateway API compatibility doc Co-authored-by: Kate Osborn <k.osborn@f5.com>
Proposed changes
Problem: No user-facing documentation for configuring TLS Passthrough
Solution: Add a how-to guide for TLS Passthrough and update Gateway API compatibility doc
Closes #2285
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.