-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cross-namespace routing with TLSRoutes #2379
Merged
kate-osborn
merged 3 commits into
nginxinc:main
from
kate-osborn:feat/ref-grant-for-tlsroute
Aug 14, 2024
Merged
Support cross-namespace routing with TLSRoutes #2379
kate-osborn
merged 3 commits into
nginxinc:main
from
kate-osborn:feat/ref-grant-for-tlsroute
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
=======================================
Coverage 88.85% 88.86%
=======================================
Files 100 100
Lines 7513 7515 +2
Branches 50 50
=======================================
+ Hits 6676 6678 +2
Misses 781 781
Partials 56 56 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Aug 12, 2024
lucacome
reviewed
Aug 13, 2024
bjee19
reviewed
Aug 13, 2024
bjee19
approved these changes
Aug 13, 2024
kate-osborn
force-pushed
the
feat/ref-grant-for-tlsroute
branch
3 times, most recently
from
August 13, 2024 21:16
0c006d0
to
ee14bad
Compare
lucacome
reviewed
Aug 13, 2024
lucacome
approved these changes
Aug 13, 2024
kate-osborn
force-pushed
the
feat/ref-grant-for-tlsroute
branch
from
August 14, 2024 15:49
97322ce
to
3792ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: With TLSRoutes, it's not possible to route to a backend in a different namespace than the route itself.
Solution: Allow users to grant TLSRoutes permission to reference backends in different namespaces using ReferenceGrants.
Testing: Ran conformance test and manual testing
Closes #2139
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.