Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross-namespace routing with TLSRoutes #2379

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: With TLSRoutes, it's not possible to route to a backend in a different namespace than the route itself.

Solution: Allow users to grant TLSRoutes permission to reference backends in different namespaces using ReferenceGrants.

Testing: Ran conformance test and manual testing

Closes #2139

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Support cross-namespace routing with TLSRoutes

@kate-osborn kate-osborn requested a review from a team as a code owner August 12, 2024 21:28
@github-actions github-actions bot added the enhancement New feature or request label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (4ac4b5f) to head (3792ed1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2379   +/-   ##
=======================================
  Coverage   88.85%   88.86%           
=======================================
  Files         100      100           
  Lines        7513     7515    +2     
  Branches       50       50           
=======================================
+ Hits         6676     6678    +2     
  Misses        781      781           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn requested a review from lucacome August 13, 2024 20:57
@kate-osborn kate-osborn force-pushed the feat/ref-grant-for-tlsroute branch 3 times, most recently from 0c006d0 to ee14bad Compare August 13, 2024 21:16
@kate-osborn kate-osborn requested a review from lucacome August 13, 2024 21:42
@kate-osborn kate-osborn force-pushed the feat/ref-grant-for-tlsroute branch from 97322ce to 3792ed1 Compare August 14, 2024 15:49
@kate-osborn kate-osborn merged commit 6625a41 into nginxinc:main Aug 14, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable TLSRoutes to route to another namespace
4 participants