Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch version to site/go.mod #2934

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Dec 19, 2024

Problem: As of Go 1.21, toolchain versions must use the 1.N.P syntax. This is causing a warning from CodeQL in our pipelines.

Solution: Add the minimum patch version.

Problem: As of Go 1.21, toolchain versions must use the 1.N.P syntax. This is causing a wanring from CodeQL in our pipelines.

Solution: Add the minimum patch version.
@sjberman sjberman requested review from a team as code owners December 19, 2024 18:25
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 19, 2024
@sjberman sjberman enabled auto-merge (squash) December 19, 2024 18:26
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (8cf2608) to head (d007b0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2934   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         109      109           
  Lines       11150    11150           
  Branches       50       50           
=======================================
  Hits        10007    10007           
  Misses       1083     1083           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman merged commit f82f001 into nginxinc:main Dec 19, 2024
42 checks passed
@sjberman sjberman deleted the chore/go-toolchain branch December 19, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants