Exact PathMatch support for HTTPRoutes #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kate-osborn
requested changes
May 1, 2023
|
@sjberman it would be nice to have an example that uses Exact Path Match. We probably don't need a new example, but maybe one of the routes in the Since we aren't running conformance tests yet, we don't have a way to ensure we haven't regressed. We typically run through the examples before releasing as a sanity check to ensure we haven't broken any features. |
pleshakov
suggested changes
May 2, 2023
pleshakov
reviewed
May 3, 2023
Add support for Exact PathMatch in an HTTPRoute. Internal locations now include the type of path (prefix, exact, regex) in the path name to distinguish between the possibility of the same path name being used with different path match types. nginx conf is updated to include "= " in the location path if that path has been defined as "Exact".
kate-osborn
requested changes
May 4, 2023
kate-osborn
approved these changes
May 4, 2023
sjberman
added a commit
to sjberman/nginx-gateway-fabric
that referenced
this pull request
May 4, 2023
* Exact PathMatch support for HTTPRoutes Add support for Exact PathMatch in an HTTPRoute. Internal locations now include the type of path (prefix, exact, regex) in the path name to distinguish between the possibility of the same path name being used with different path match types. nginx conf is updated to include "= " in the location path if that path has been defined as "Exact".
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Exact PathMatch in an HTTPRoute. Internal locations now include the type of path (prefix, exact, regex) in the path name to distinguish between the possibility of the same path name being used with different path match types.
nginx conf is updated to include "= " in the location path if that path has been defined as "Exact".
Closes #476